SL24W25 - Revision history

Kademlia at 21:39, 23 June 2024

2024-06-23T21:39:16Z

← Older revision		Revision as of 21:39, 23 June 2024
Line 39:		Line 39:
	***		***
	**'''Fixing hotswapping laggyness in Java 21:'''		**'''Fixing hotswapping laggyness in Java 21:'''
	***'''~~Call~~ System.~~gc()~~ on ~~a detected change as the simplest hotfix~~'''		***'''Simplest fix: Not using G1Gc as it does not seem to be fixable'''
			***'''Instead use '-XX:+DoEscapeAnalysis -XX:+UseSerialGC -XX:-SegmentedCodeCache -XX:ReservedCodeCacheSize=96m -XX:StartAggressiveSweepingAt=50''''
			***'''And force a System.GC on every hotswap interaction'''
	***Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity		***Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity
	***StartAggressiveSweepingAt, SweeperThreshold		***StartAggressiveSweepingAt, SweeperThreshold

2024-06-23T17:11:27Z

@@ Line 42: / Line 42: @@
 ***Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity
 ***StartAggressiveSweepingAt, SweeperThreshold
 ***

2024-06-23T16:56:19Z

← Older revision		Revision as of 16:56, 23 June 2024
Line 30:		Line 30:
	*'''Hotswapping laggyness'''		*'''Hotswapping laggyness'''
	**Increasing these does not help WEBBIGBOISNOW='-XX:+SegmentedCodeCache -XX:NonProfiledCodeHeapSize=32m -XX:ProfiledCodeHeapSize=128m -XX:NonNMethodCodeHeapSize=64m -XX:ReservedCodeCacheSize=224m'		**Increasing these does not help WEBBIGBOISNOW='-XX:+SegmentedCodeCache -XX:NonProfiledCodeHeapSize=32m -XX:ProfiledCodeHeapSize=128m -XX:NonNMethodCodeHeapSize=64m -XX:ReservedCodeCacheSize=224m'
	**~~We get~~		**'''A lot of classes are loaded multiple times by multiple classloaders? Is this normal for hotswapping?'''
	**Bug seems to be from either:		**Bug seems to be from either:
	***Java 21 in general		***Java 21 in general
Line 37:		Line 37:
	***G1GC?		***G1GC?
	***(MC changes?)		***(MC changes?)
			***
			**'''Fixing hotswapping laggyness in Java 21:'''
			***'''Call System.gc() on a detected change as the simplest hotfix'''
			***Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity
			***StartAggressiveSweepingAt, SweeperThreshold
			***

2024-06-23T16:17:15Z

← Older revision		Revision as of 16:17, 23 June 2024
Line 28:		Line 28:
	** '''EnchantmentFrostWalker if(true) return; // kade edit disable frost walker'''		** '''EnchantmentFrostWalker if(true) return; // kade edit disable frost walker'''
	** '''FIx HeightMap.Type.GROWTH_HEIGHTMAP'''		** '''FIx HeightMap.Type.GROWTH_HEIGHTMAP'''
			*'''Hotswapping laggyness'''
			**Increasing these does not help WEBBIGBOISNOW='-XX:+SegmentedCodeCache -XX:NonProfiledCodeHeapSize=32m -XX:ProfiledCodeHeapSize=128m -XX:NonNMethodCodeHeapSize=64m -XX:ReservedCodeCacheSize=224m'
			**We get
			**Bug seems to be from either:
			***Java 21 in general
			***JBR JDK 21
			***Hotswapagent
			***G1GC?
			***(MC changes?)

2024-06-23T13:41:45Z

← Older revision		Revision as of 13:41, 23 June 2024
Line 21:		Line 21:
	** '''Heavy changes to PlayerChunk, PlayerChunkMap again,'''		** '''Heavy changes to PlayerChunk, PlayerChunkMap again,'''
	** '''TicketType LIGHT removed'''		** '''TicketType LIGHT removed'''
	** '''BlockAttachedEntity (Leash)'''		** '''BlockAttachedEntity (Leash, ItemFrame, Painting)'''
	** '''ARMOR -> HUMANOID_ARMOR'''		** '''ARMOR -> HUMANOID_ARMOR'''
	** '''Remove Itemstack "trap" code?. Test foxes again for NPE'''		** '''Remove Itemstack "trap" code?. Test foxes again for NPE'''

2024-06-19T23:47:02Z

← Older revision		Revision as of 23:47, 19 June 2024
Line 19:		Line 19:
	** '''Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)'''		** '''Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)'''
	**'''PacketPlayInBlockPlace contains yRot and xRot'''		**'''PacketPlayInBlockPlace contains yRot and xRot'''
			** '''Heavy changes to PlayerChunk, PlayerChunkMap again,'''
			** '''TicketType LIGHT removed'''
			** '''BlockAttachedEntity (Leash)'''
			** '''ARMOR -> HUMANOID_ARMOR'''
			** '''Remove Itemstack "trap" code?. Test foxes again for NPE'''
			** '''Check how badly findPlayerWithOminousEffect is implemented'''
			** '''PathfinderGoalFollowOwner possibly add back that only up to 10 dogs are teleported'''
			** '''EnchantmentFrostWalker if(true) return; // kade edit disable frost walker'''
			** '''FIx HeightMap.Type.GROWTH_HEIGHTMAP'''

2024-06-18T22:05:19Z

← Older revision		Revision as of 22:05, 18 June 2024
Line 18:		Line 18:
	* '''Regarding 1.21'''		* '''Regarding 1.21'''
	** '''Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)'''		** '''Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)'''
	**		**'''PacketPlayInBlockPlace contains yRot and xRot'''

2024-06-18T20:26:12Z

← Older revision		Revision as of 20:26, 18 June 2024
Line 15:		Line 15:
	**Trademark		**Trademark
	**'''(Keep converting all the other impl)'''		**'''(Keep converting all the other impl)'''

			* '''Regarding 1.21'''
			** '''Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)'''
			**

2024-06-17T22:20:46Z

← Older revision		Revision as of 22:20, 17 June 2024
Line 14:		Line 14:
	**Skin		**Skin
	**Trademark		**Trademark
			**'''(Keep converting all the other impl)'''

2024-06-17T21:44:25Z

← Older revision		Revision as of 21:44, 17 June 2024
Line 1:		Line 1:
	[[SL24W24\|◄ SL24W24]] \| [[SL24W26\|SL24W26 ►]]		[[SL24W24\|◄ SL24W24]] \| [[SL24W26\|SL24W26 ►]]

			* '''Reverted to Eclipse 2024-03 as 2024-06 is unusable'''
			** https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2574
			** https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2093
			** https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2540

	*'''Slowly go trough all Features and convert to optioned'''		*'''Slowly go trough all Features and convert to optioned'''