SL24W25: Difference between revisions

From ETM
Jump to navigation Jump to search
No edit summary
No edit summary
 
(3 intermediate revisions by the same user not shown)
Line 28: Line 28:
** '''EnchantmentFrostWalker if(true) return; // kade edit disable frost walker'''
** '''EnchantmentFrostWalker if(true) return; // kade edit disable frost walker'''
** '''FIx HeightMap.Type.GROWTH_HEIGHTMAP'''
** '''FIx HeightMap.Type.GROWTH_HEIGHTMAP'''
*'''Hotswapping laggyness'''
**Increasing these does not help WEBBIGBOISNOW='-XX:+SegmentedCodeCache -XX:NonProfiledCodeHeapSize=32m -XX:ProfiledCodeHeapSize=128m -XX:NonNMethodCodeHeapSize=64m -XX:ReservedCodeCacheSize=224m'
**'''A lot of classes are loaded multiple times by multiple classloaders? Is this normal for hotswapping?'''
**Bug seems to be from either:
***Java 21 in general
***JBR JDK 21
***Hotswapagent
***G1GC?
***(MC changes?)
***
**'''Fixing hotswapping laggyness in Java 21:'''
***'''Simplest fix: Not using G1Gc as it does not seem to be fixable'''
***'''Instead use '-XX:+DoEscapeAnalysis -XX:+UseSerialGC -XX:-SegmentedCodeCache -XX:ReservedCodeCacheSize=96m -XX:StartAggressiveSweepingAt=50''''
***'''And force a System.GC on every hotswap interaction'''
***Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity
***StartAggressiveSweepingAt, SweeperThreshold
***
<syntaxhighlight lang="java">
[2024-06-23 17:10:31]: [🖥] ==== ignoring REDEFINITION ==== net/minecraft/world/entity/animal/EntityFox$h
>[125.678s][warning][codecache] CodeHeap 'non-profiled nmethods' is full. Compiler has been disabled.
[125.678s][warning][codecache] Try increasing the code heap size using -XX:NonProfiledCodeHeapSize=
OpenJDK 64-Bit Server VM warning: CodeHeap 'non-profiled nmethods' is full. Compiler has been disabled.
OpenJDK 64-Bit Server VM warning: Try increasing the code heap size using -XX:NonProfiledCodeHeapSize=
CodeHeap 'non-profiled nmethods': size=32768Kb used=32767Kb max_used=32767Kb free=0Kb
bounds [0x00007ff90a450000, 0x00007ff90c450000, 0x00007ff90c450000]
CodeHeap 'profiled nmethods': size=131072Kb used=131056Kb max_used=131056Kb free=15Kb
bounds [0x00007ff8fe450000, 0x00007ff906450000, 0x00007ff906450000]
CodeHeap 'non-nmethods': size=65536Kb used=5695Kb max_used=5774Kb free=59840Kb
bounds [0x00007ff906450000, 0x00007ff906a70000, 0x00007ff90a450000]
total_blobs=59273 nmethods=57534 adapters=1632
compilation: disabled (not enough contiguous free space left)
              stopped_count=1, restarted_count=0
full_count=1
</syntaxhighlight>
***

Latest revision as of 21:39, 23 June 2024

◄ SL24W24 | SL24W26 ►

  • Slowly go trough all Features and convert to optioned
    • Chat
    • Crafting
    • Crate
    • Channel
    • Head
    • Skin
    • Trademark
    • (Keep converting all the other impl)
  • Regarding 1.21
    • Check out what "Tools" are as the naming conflicts with ours (CraftToolComponent)
    • PacketPlayInBlockPlace contains yRot and xRot
    • Heavy changes to PlayerChunk, PlayerChunkMap again,
    • TicketType LIGHT removed
    • BlockAttachedEntity (Leash, ItemFrame, Painting)
    • ARMOR -> HUMANOID_ARMOR
    • Remove Itemstack "trap" code?. Test foxes again for NPE
    • Check how badly findPlayerWithOminousEffect is implemented
    • PathfinderGoalFollowOwner possibly add back that only up to 10 dogs are teleported
    • EnchantmentFrostWalker if(true) return; // kade edit disable frost walker
    • FIx HeightMap.Type.GROWTH_HEIGHTMAP
  • Hotswapping laggyness
    • Increasing these does not help WEBBIGBOISNOW='-XX:+SegmentedCodeCache -XX:NonProfiledCodeHeapSize=32m -XX:ProfiledCodeHeapSize=128m -XX:NonNMethodCodeHeapSize=64m -XX:ReservedCodeCacheSize=224m'
    • A lot of classes are loaded multiple times by multiple classloaders? Is this normal for hotswapping?
    • Bug seems to be from either:
      • Java 21 in general
      • JBR JDK 21
      • Hotswapagent
      • G1GC?
      • (MC changes?)
    • Fixing hotswapping laggyness in Java 21:
      • Simplest fix: Not using G1Gc as it does not seem to be fixable
      • Instead use '-XX:+DoEscapeAnalysis -XX:+UseSerialGC -XX:-SegmentedCodeCache -XX:ReservedCodeCacheSize=96m -XX:StartAggressiveSweepingAt=50'
      • And force a System.GC on every hotswap interaction
      • Force enable UseCodeCacheFlushing, MethodFlushing, NmethodSweepActivity
      • StartAggressiveSweepingAt, SweeperThreshold
[2024-06-23 17:10:31]: [🖥] ==== ignoring REDEFINITION ==== net/minecraft/world/entity/animal/EntityFox$h
>[125.678s][warning][codecache] CodeHeap 'non-profiled nmethods' is full. Compiler has been disabled.
[125.678s][warning][codecache] Try increasing the code heap size using -XX:NonProfiledCodeHeapSize=
OpenJDK 64-Bit Server VM warning: CodeHeap 'non-profiled nmethods' is full. Compiler has been disabled.
OpenJDK 64-Bit Server VM warning: Try increasing the code heap size using -XX:NonProfiledCodeHeapSize=
CodeHeap 'non-profiled nmethods': size=32768Kb used=32767Kb max_used=32767Kb free=0Kb
 bounds [0x00007ff90a450000, 0x00007ff90c450000, 0x00007ff90c450000]
CodeHeap 'profiled nmethods': size=131072Kb used=131056Kb max_used=131056Kb free=15Kb
 bounds [0x00007ff8fe450000, 0x00007ff906450000, 0x00007ff906450000]
CodeHeap 'non-nmethods': size=65536Kb used=5695Kb max_used=5774Kb free=59840Kb
 bounds [0x00007ff906450000, 0x00007ff906a70000, 0x00007ff90a450000]
 total_blobs=59273 nmethods=57534 adapters=1632
 compilation: disabled (not enough contiguous free space left)
              stopped_count=1, restarted_count=0
 full_count=1